search

Novum / vkQuake

Vulkan Quake port based on QuakeSpasm
GNU General Public License v2.0
1.83k stars 222 forks source link

AppImage release archives use commit hash instead of the release tag #722

Open j4reporting opened 2 months ago

j4reporting commented 2 months ago

the Linux appImages release archives use the commit hash instead the release tag in the directory name

$ tar tvf vkquake-1.31.1_linux64.tar.gz
drwxr-xr-x root/root         0 2024-08-02 18:45 vkquake-f09814e9_linux64/
-rwxr-xr-x root/root   2778304 2024-08-02 18:45 vkquake-f09814e9_linux64/vkquake.AppImage
-rw-r--r-- root/root     18092 2024-08-02 18:45 vkquake-f09814e9_linux64/LICENSE.txt

$ tar tvf vkquake-1.30.1_linux64.tar.gz
drwxr-xr-x root/root         0 2023-03-15 04:00 vkquake-1.30.1_linux64/
-rwxr-xr-x root/root   2720960 2023-03-15 04:00 vkquake-1.30.1_linux64/vkquake.AppImage
-rw-r--r-- root/root     18092 2023-03-15 04:00 vkquake-1.30.1_linux64/LICENSE.txt
vsonnier commented 2 months ago

Thanks, that should be fixed.

Update : not really ?

vsonnier commented 2 months ago

OK still not good. I'll let more competent people try their turn.

Introduced by e8cf9edb1117f9f7ac856cf35c9a54d4439a6c2b ?

j4reporting commented 2 months ago

I don´t see where build-appimage.sh would run. It looks like this could be part of an extra release build process and should run when a new tag was created. Here VERSION is set to the version string extracted from quakedef.h or now quakever.h and then it starts the normal

The push/merge linux ci process uses run-in-docker.sh with VERSION set to the commit hash, and that should remain as it is.

The latest release is identical to the CI process for the new tag and renamed to vkquake_1.31.1_linux.tar.gz. This will not change the name of archived directory.

j4reporting commented 2 months ago

It could have been a temporary release branch with a modified docker statement to build the image with build-appimage.sh instead of run-in-docker.sh