Novusphere / discussions-vue

A Vue.js implementation of Discussions using the novusphere-js API - https://discussions.app
MIT License
12 stars 8 forks source link

Change EOSGO to Logo aligned with the text in Wallets/Assets #251

Closed bluabaleno closed 3 years ago

bluabaleno commented 4 years ago

EOS GO credit Link to http://eosgo.io

Novusphere commented 4 years ago

image

bluabaleno commented 4 years ago

Can we replace the text with their logo? png: https://github.com/eosasia/branding/blob/master/eos%20go%20/logos/eosgologo-isolated.png?raw=true

bluabaleno commented 4 years ago

Now that I had another look at it after some time, for a new users/content creator it's the EOS value of the tokens is sort of meaningless

I'm still oppose to displaying the dollar amount on posts, but I think for the wallet that's not a bad idea. @Novusphere

Novusphere commented 4 years ago

Basically another case of the image isn't nicely sized to be used in the same line as text so while I know exactly what you want, spending on the time on it doesn't really seem the best use of time. An easier solution to this is if they are the ones who want this to just get a single image that says "Price feed provided by EOSGO" or something more generic might be "powered by EOSGO" this way it's not text + an image but just an image.

Novusphere commented 4 years ago

Also I don't quite get what your second comment is saying. Do you want the EOS price removed and instead for it to display the dollar price? The dollar value of their tokens? Or what?

bluabaleno commented 3 years ago

Also I don't quite get what your second comment is saying. Do you want the EOS price removed and instead for it to display the dollar price? The dollar value of their tokens? Or what?

yeah ATMOS/EOS don't mean much for users outside of EOS.

Novusphere commented 3 years ago

Got it, I'll change it to USD then.

bluabaleno commented 3 years ago

Will close this issue. Further refinements to be addressed in another issue.