search

Nowaha / Shop-by-Conjurate

1.14 update for the Shop plugin by Conjurate. Original: https://www.spigotmc.org/resources/shop.8185/
0 stars 11 forks source link

Sell function ignoring NBT data. #24

Closed Vyrgax closed 4 years ago

Vyrgax commented 4 years ago

The sell function in the shop ignores data such as name, lore, and custommodeldata, and subtracts the amount of sold items of from other similar items as well:

Let's say you want to sell 3 Iron Ingots with the name Apple. You also have 6 Iron Ingots with the name Banana, as well as 9 Iron Ingots with the name Pear.

If you'd sell 3 of the "Apple" iron ingots, the shop takes 3 of the apples, 3 of the bananas, and 3 of the pears as well. You'd then have 0 apples, 3 bananas, and 6 pears.

This basically renders the plugin broken.

Vyrgax commented 4 years ago

I'm using 1.14.4 (paper), and the latest snapshot (Shop-by-Conjurate-2.1.5-SNAPSHOT build 10)

Huskehhh commented 4 years ago

I've now pushed a commit that should address this. I apologise for the oversight on my behalf when I changed the selling logic.