search

NoxArt / SublimeText2-FTPSync

Simple and free FTP(S) syncing (SFTP not available)
MIT License
342 stars 65 forks source link

Overwriting: Server time issue #152

Open saiori opened 10 years ago

saiori commented 10 years ago

Hopefully not a duplicate of this issue: https://github.com/NoxArt/SublimeText2-FTPSync/issues/143

Hello again! Thanks again for all your hard work on FTPSync, without it, ST2 would be so much less to me.

We have just started having an issue with a server that we do a lot of work with. The server time is set to EDT. We are located in CDT.

When we save a file (upload on save:true) it asks us to confirm that we want to overwrite every time. When we look at the file on the server it has the server's time correctly.

If we change our PC clock to be 1 hour ahead, thus matching EDT, we no longer have this problem.

We have tried setting set_remote_lastmodified to false, but it does not seem to help with the issue.

Please let me know if I can give you any logs or any other assistance in helping out with this issue.

It does seem that this issue only recently showed up and before was not a problem for us. We're not exactly sure what might have changed. We don't think the server environment has been changed recently.

NoxArt commented 10 years ago

Hi, there's not only time difference, but also size difference considered ... but maybe I missed a case when it passes when it should not. I'll take a look at it when I get to pc.

NoxArt commented 10 years ago

I added debug print, activate by

...
"debug_extras" {
    "debug_overwrite_prevention": true
}

hope it helps

saiori commented 10 years ago

I'm sorry, but I'm not exactly sure where/how to put that into my ftpsync.settings file.

Thanks!

*Edit: Didn't need to include a salutation :)

NoxArt commented 10 years ago

Like this:

"default": {

   "host": "...",
   "username": "...",
   "password": "...",
   "path": "...",
   "debug_extras" {
        "debug_overwrite_prevention": true
    }

}
saiori commented 10 years ago

I thought that was the way, but when i do, I get an error about parsing configuration.

{ "default": {

"host": "somedomain.com", "username": "someusername", // or null for anonymous login "password": "somepassword", "path": "somepath",

"upload_on_save": true, // set false if you do not want to upload on save! "download_on_open": true,

            "debug_extras" {
               "debug_overwrite_prevention": true
            }

} }

Failed parsing configuration file: {...\ftpsync.settings} (commas problem?) [Exception: Expecting : delimiter: line 12 column 19 (char 226)]

I thought maybe it was the lack of a colon after debug_extras, but that didn't help.

On Tue, May 6, 2014 at 2:04 PM, Jiří Petruželka notifications@github.comwrote:

Like this:

"default": {

"host": "...", "username": "...", "password": "...", "path": "...", "debug_extras" { "debug_overwrite_prevention": true }

}

— Reply to this email directly or view it on GitHubhttps://github.com/NoxArt/SublimeText2-FTPSync/issues/152#issuecomment-42344857 .

NoxArt commented 10 years ago

Oh, sorry, there's a missing : after "debug_extras", so

"debug_extras":
saiori commented 10 years ago

I had to restart ST2. That solved the issue.

Here is the log: Writing file [..]/file_upload_progress.php with encoding UTF-8 FTPSync [default] > Connected to: somedomain.com:21 (timeout: 30) (key: somekey) FTPSync [default] > Logged in as: someuser (using password: YES) FTPSync > Closing connection FTPSync > dumping overwrite prevention Enabled: True Not in blacklist: True Is remote newer: True Is size different: True In overwrite cancelled: False

On Tue, May 6, 2014 at 2:16 PM, Jiří Petruželka notifications@github.comwrote:

Oh, sorry, there's a missing : after "debug_extras", so

"debug_extras":

— Reply to this email directly or view it on GitHubhttps://github.com/NoxArt/SublimeText2-FTPSync/issues/152#issuecomment-42346203 .

saiori commented 10 years ago

As you can see, I saved the same file twice with a small change in between the saves.

Both times required me to authorize the overwrite.

The only thing I can think of is there is an issue with daylight savings time. I don't believe that anything has changed with the server recently.

I wasn't sure if you had changed something recently with ftpsync. We only noticed this in the last week or so.

NoxArt commented 10 years ago

That possible, but also it's weird that the size is reported different both times. Can you please check using other programs what is the actual size (locally and remotely)? Thank you! (you can also add print_list_result into debug_extras, will print results when FTPSync checks a file stats (or contents of a folder); for all debug_extras see https://github.com/NoxArt/SublimeText2-FTPSync/blob/master/FTPSync.sublime-settings#L48 )

saiori commented 10 years ago

FileZilla: Local file: 411 bytes @ 2014/05/06 2:41:47 PM Remote file: 411 bytes @ 2014/05/06 2:42:00 PM

Shell: Remote file: 411 bytes @ 2014/05/06 15:42 (3:42 PM)

Windows Explorer: Local File: 1 KB @ 2014/05/06 2:41 PM

On Tue, May 6, 2014 at 2:36 PM, Jiří Petruželka notifications@github.comwrote:

That possible, but also it's weird that the size is reported different both times. Can you please check using other programs what is the actual size (locally and remotely)? Thank you! (you can also add print_list_result into debug_extras, will print results when FTPSync checks a file stats (or contents of a folder); for all debug_extras see https://github.com/NoxArt/SublimeText2-FTPSync/blob/master/FTPSync.sublime-settings#L48)

— Reply to this email directly or view it on GitHubhttps://github.com/NoxArt/SublimeText2-FTPSync/issues/152#issuecomment-42348562 .

saiori commented 10 years ago

Just checking in on this issue. Can you see anything in the debug stuff that might indicate the issue? We are still experiencing the issue. We did find out that the one server it is happening on just recently updated to Apache. I'll try to find out what version that was and get back to you with it if you think it's important.

saiori commented 10 years ago

Apache HTTP Server 2.4.9

NoxArt commented 10 years ago

Hi, I apologize, 'm finishing my thesis at the moment, so it kinda stalled lately ... HTTP Server should not play a role as this should be handled by FTP Server.

Overwrite protection should not trigger unless the size differs too, and that should be the same (as you've found out), so it either fetches size wrongly or from wrong files probably. I slightly modified the debug_extras options to show source files as well.

If you have time please also check print_list_results as there should be a line containing a filesize that FTPSync extracts. Thanks!