search

NoxHarmonium / peoples-choice

People's Choice is a web application that lets people vote for their colleagues
Apache License 2.0
2 stars 1 forks source link

Use eslint-plugin-total-functions #18

Closed danielnixon closed 4 years ago

NoxHarmonium commented 4 years ago

Are the exceptions you put in due to limitations in the plugin or are they things we should fix? If it is the latter I might push up a commit to make the linter happy.

danielnixon commented 4 years ago

I believe I fixed all the false positives in the plugin, so these are all just grandfathered in.

danielnixon commented 4 years ago

Although https://github.com/danielnixon/eslint-plugin-total-functions/issues/11 would remove the need for at least one.

danielnixon commented 4 years ago

And https://github.com/danielnixon/eslint-plugin-total-functions/issues/18 would probably help too

NoxHarmonium commented 4 years ago

I don't have time to fix these issues right now so I've raised https://github.com/NoxHarmonium/peoples-choice/issues/19 and will merge this.