search

NoxHarmonium / peoples-choice

People's Choice is a web application that lets people vote for their colleagues
Apache License 2.0
2 stars 1 forks source link

Casting votes in quick succession presents a visual bug #4

Closed PouriaSterling closed 4 years ago

PouriaSterling commented 4 years ago

Only the last vote cast displays as voted for when multiple votes are cast quickly, however refreshing the page correctly shows all of those people as voted for.

Could either fix it so it correctly shows all 3 even if voting is done quickly, or alternatively disable voting while an existing vote is being processed.

NoxHarmonium commented 4 years ago

Hmmm I thought I made the button disabled while the API request was in progress. Seems like that didn't work

PouriaSterling commented 4 years ago

Yeah seems not.

I can even abuse this to vote 4 times (not more than 4 though)

PouriaSterling commented 4 years ago

And when I'm at -1 vote remaining, I can still cast more votes which all return 400 You have already voted the maximum number of times (3)