Closed treierxyz closed 3 years ago
Hello,
I will not merge this PR as I disagree with all of thoses changes.
Changing the username variable will not fix anything, I'm not able to reproduce the bug you talk, and I think your problem is elsewhere.
The P2P port variable is not a prerequisite for the server to launch proprely, and is not needed as such.
I made the /forceip required as it can resolve quickly issues from being behind firewall/nat/reverse-proxy stuff. I can understand why you wish to remove it as in simple setup you may not need it, but as Pterodactyl is made for non-technical users, forcing them to fill the public IP may avoid encountering network issues later.
As for use chown -Rv 1000: because it saves 4 characters
, you will just get an error. eg:
# touch file
# chown 2000: file
chown: invalid spec: ‘2000:’
# ll file
-rw-rw-r-- 1 myuser myuser 0 janv. 6 13:59 file
The pterodactyl setup is less elegant than the main Dockerfile/entrypoint, but it's because its inner working is pretty fucked up, sadly.
Edit: If you really want those, better fork and keep your changes for your own use.
Alright, I will keep these changes to myself. Do note that all of these changes are still in my PyPlanet fork, so I guess that PR will be closed too.
/forceip
option in startup command)/forceip
from startup commandchown -Rv 1000:
because it saves 4 characters