search

Noxwizard / dnscrypt-winclient

Windows client for managing the DNSCrypt Proxy
MIT License
404 stars 81 forks source link

Extended shouldHide method #22

Closed bitbeans closed 9 years ago

bitbeans commented 9 years ago
Noxwizard commented 9 years ago

What version of Windows is using this hyphenated name?

bitbeans commented 9 years ago

8.1 64 bit

Noxwizard commented 9 years ago

I do not see this on my 8.1 x64 machine. Are you using a localized version of Windows? I do see that Microsoft changed the description on the Teredo adapter in 8.1 and 10, which means I should probably switch to checking names and not descriptions. I do not see this change though.

bitbeans commented 9 years ago

Yes i use a german version.

bitbeans commented 9 years ago

An here is a screenshot on a Windows 10 notebook (x64 german version): w10

bitbeans commented 9 years ago

@Noxwizard status? :)

Noxwizard commented 9 years ago

It's very unlikely this will be merged. The root of the problem is caused by the application looking at adapter descriptions, which have the potential to be translated differently in localized versions of Windows. The correct fix would be to find a device identifier (Hardware ID, Device Instance Path, etc.) that is not changed between versions. This PR also has other commits attached with no reasoning as to why, as well as breaking formatting styles.