search

NoxyNixie / Noxys_Trees

A Factorio modification that makes the trees spread slowly but also die off with certain condition.
https://mods.factorio.com/mods/CobaltSky/Noxys_Trees
The Unlicense
9 stars 5 forks source link

Trees growin on item ghosts. #3

Closed staviq closed 6 years ago

staviq commented 6 years ago

Hi, should check for placed item ghosts when growing new trees.

I had this happen many times until i realized what's going on.

If you place a blueprint, and then say run out of items, you go back to the main base, and return to your placed blueprint, new trees can grow in that area, and bots will not build because the new trees are not marked for deconstruction.

NoxyNixie commented 6 years ago

Ah yeah that is a good one. I'll have a look at that momentarily and probably have a build in a few hours with that fixed ;)

NoxyNixie commented 6 years ago

Ok I just tested and trees shouldn't spawn on player build ghost entities because of the Minimum distance to player entities setting.

If you changed that to 0 or close to 0 then trees ignoring ghosts should be expected behavior.

The default for that setting is 2 so no trees should get closer than that to an entity.

Even with entities much larger than 2 tiles it still does not on my end clear or grow into ghost entities because factorio is smart and uses bounding boxes to check entities in an area.

NoxyNixie commented 6 years ago

Closing this as it does not appear to actually be an issue with the right (default) settings:

staviq commented 6 years ago

It definitely is still happening for me, and usually with small item ghosts like belts or inserters.

NoxyNixie commented 6 years ago

Can you tell me your settings and maybe show a screenshot? Or a world download?

staviq commented 6 years ago

I have tried to reproduce and found that this happens not only with trees but also with rocks. Does your mod do anything with rocks? Because if it doesn't the problem is elsewhere entirely.

NoxyNixie commented 6 years ago

Absolutely not. You may have some other mod doing some odd stuff then ;)

staviq commented 6 years ago

Alright then, sorry for bothering you :)

NoxyNixie commented 6 years ago

No problem. For future reference did you find out what mod does do it?

staviq commented 6 years ago

Not yet, but there seems to be a problem with factorio forgetting things were marked for deconstruction.

staviq commented 6 years ago

Quick question, can you tell if a tree was grown by factorio mapgen or by your mod given a game save and no log ?

NoxyNixie commented 6 years ago

Not easily. Only way I know of is to create a new world with exact same settings but noxys trees disabled and then comparing the two worlds side by side. Vanilla does not spread trees so the initial world creation trees should be identical.

staviq commented 6 years ago

Ok thanks.