search

Nozbe / WatermelonDB

🍉 Reactive & asynchronous database for powerful React and React Native apps ⚡️
https://watermelondb.dev
MIT License
10.62k stars 600 forks source link

Add json decorator options to TS type #1808

Closed martyfitzer-ids closed 4 months ago

martyfitzer-ids commented 4 months ago

Modifies the json property decorator TS type to support an options object as a third function argument that the JS implementation supports.

martyfitzer-ids commented 4 months ago

Hi @radex, do you have any idea why the windows tests check failed?

radex commented 4 months ago

@martyfitzer-ids I don't know for sure, but don't worry about it -- it was broken before your changes. Seems like a Visual Studio update on GitHub's side broke it. I may have to bump React Native to a newer version for Windows CI to work again.

radex commented 4 months ago

thanks for the TS improvement!