Nozbe / withObservables

HOC (Higher-Order Component) for connecting RxJS Observables to React Components
https://github.com/Nozbe/WatermelonDB
MIT License
66 stars 26 forks source link

@nozbe/with-observables@latest is not compatible with @nozbe/watermelondb@latest #135

Closed mfbx9da4 closed 1 year ago

mfbx9da4 commented 1 year ago

I can see you intend to merge with-observables into the main project. That's great and makes sense but for now installing watermelon breaks:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! Found: @types/react@18.0.38
npm ERR! node_modules/@types/react
npm ERR!   dev @types/react@"^18.0.25" from the root project
npm ERR!   @types/react@"*" from @types/hoist-non-react-statics@3.3.1
npm ERR!   node_modules/@types/hoist-non-react-statics
npm ERR!     peer @types/hoist-non-react-statics@"^3.3.1" from @nozbe/with-observables@1.4.1
npm ERR!     node_modules/@nozbe/with-observables
npm ERR!       @nozbe/with-observables@"1.4.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @types/react@"^16.9.23||^17" from @nozbe/with-observables@1.4.1
npm ERR! node_modules/@nozbe/with-observables
npm ERR!   @nozbe/with-observables@"1.4.1" from the root project

For now I've resolve with

npm i @nozbe/with-observables@1.5.0-3

Is this recommended?

radex commented 1 year ago

@mfbx9da4 You should remove with-observables dependency, WatermelonDB already specifies the expected with-observables version