search

Nozbe / withObservables

HOC (Higher-Order Component) for connecting RxJS Observables to React Components
https://github.com/Nozbe/WatermelonDB
MIT License
68 stars 26 forks source link

Fix TS bindings #60

Closed jamieparkinson closed 5 years ago

jamieparkinson commented 5 years ago

Sorry about this - my test case missed a pretty obvious thing, should be fixed in here. Possibly some more fixes/improvements to come if I find them!

Given there's been no release I thought there was no point in adding to the changelog, let me know if you'd still like it.

radex commented 5 years ago

Given there's been no release

Uhh, I just released your changes this morning :)

jamieparkinson commented 5 years ago

Ah, sorry about that - perhaps you could look at switching to using GitHub tags/releases as the source of truth rather than NPM, I've found it makes tracking changes easier as they are currently not in sync.

Anyway, just pushed the updated changelog including today's release as per https://keepachangelog.com, thank you!

radex commented 5 years ago

@jamieparkinson ah, no, it's my fault - I forgot I don't have a release script in this repo that automatically pushes to git :)

radex commented 5 years ago

@jamieparkinson tell me what you prefer - I can release this right now if you think it's good, or you can patch this on your side and after a week or something, if you find no more issues, I can release then

jamieparkinson commented 5 years ago

Yeah let's wait a few days, at least there's something that works partially out there. I've been using these fixed bindings all day today and haven't come across anything problematic so far 🤞 - will confirm mid next week.

jamieparkinson commented 5 years ago

Hey @radex, been writing pretty much nothing but WatermelonDB & withObservables all week and am quite happy with this version of the types: I've added a helper method that I ended up making and documented it in the README :) Let me know what you think!