search

Nozbe / withObservables

HOC (Higher-Order Component) for connecting RxJS Observables to React Components
https://github.com/Nozbe/WatermelonDB
MIT License
68 stars 26 forks source link

Fix Types (Hoist Statics and Props Inference) #90

Closed azizhk closed 4 years ago

azizhk commented 4 years ago

@radex This is ready now. Fixes Props Inference and Hoists Statics.

CC: @jamieparkinson Would love if you could review also.

jamieparkinson commented 4 years ago

Ha, I no longer work with this library or even with TS/JS at all but this does look good to me. I remember not being especially happy with what I'd done at the time, and being vaguely aware that there were some holes in it, and your (very clear) explanatory comments sound familiar re the complexity that had to be captured - so I'd trust that this is a good job!

azizhk commented 4 years ago

your (very clear) explanatory comments

😅 the code including comments have been taken from react-redux's types.

radex commented 4 years ago

@azizhk Hey! Thank you for your contribution. I wish you'd pinged me about it, because I must have missed (or forgotten) about this PR. Do you mind fixing up the conflict? I would love to merge it

azizhk commented 4 years ago

Can I create a new PR and get Hacktoberfest credit? 😅

radex commented 4 years ago

@azizhk heck yeah dude, get that t-shirt!

azizhk commented 4 years ago

Thanks @radex. Closed in favor of https://github.com/Nozbe/withObservables/pull/98