search

Nozbe / withObservables

HOC (Higher-Order Component) for connecting RxJS Observables to React Components
https://github.com/Nozbe/WatermelonDB
MIT License
66 stars 26 forks source link

[DO NOT MERGE] withObservables, without Rx #93

Closed radex closed 3 years ago

radex commented 3 years ago

This is hand-written asynchronous logic to completely remove Rx dependency from withObservables. It certainly makes the code uglier, harder to read, and more error-prone… but this is low-level infra, we have hundreds or thousands of these, and there's a measurable performance impact of the old implementation.

radex commented 3 years ago

@kokusGr Nope, feel free to merge

kokusGr commented 3 years ago

Ok, merging. Thanks :)