NozeIO / Noze.io

Evented I/O streams for Swift
http://noze.io
307 stars 11 forks source link

Swift 3.1 #17

Closed lichtblau closed 7 years ago

lichtblau commented 7 years ago

Port to Swift 3.1 (tested with the swift-3.1-DEVELOPMENT-SNAPSHOT-2017-03-19-a-ubuntu16.10 tarball).

In this branch:

Not in this branch:

There are several ways to quiet down swift on the string interpolation of optionals. I've opted for the "as Optional" instead of ".debugDescription" for no big reason. Both seem roughly equally ugly.

helje5 commented 7 years ago

OK, I'm going to check it out tomorrow. I assume this should not affect Swift 3.0.2 builds, right? (I see Travis is passing, but still).

helje5 commented 7 years ago

readdir_r is apparently pointless

The web says it is 'harmful' ;->

The macOS man page of readdir doesn't say whether it is thread safe or not (the Linux one is for our purposes). While we are only on one thread right now, I think we should keep the doors open to run on multiple accept queues in one process.