NthMetal
commented
2 years ago Nice! Looking pretty good.
One last thing, can you add the thumbLabel attribute to the mat sliders. So users can know which value they're selecting instead of guessing. (more info on it here: https://material.angular.io/components/slider/api#MatSlider)
Will double check and merge after!
algusaem
Sorry again for doing a pull the wrong way last time!
I've checked your suggestions and did some changes. I've removed the mat form field around every slider and now it looks much better.
I've run into some troubles trying to position the % symbol close to the value of the slider, I ended up changing it to text instead so I could format it better. If you want to keep it as an input I think the easiest way of adding the % symbol is just putting it on the title of the slider like this
this would allow to keep the value as an input so the user can click and edit it without touching the slider. I think the way I did it is functional and works just fine, but I'm clarifying just in case you wanna keep it like it was before!
I've also reverted the default values of the client sliders to the ones you had before (two zeroes) since as you mentioned it was working in a weird way with the default values I gave it in the earlier pull.
Have a nice day and feel free to tell me if you want me to help with anything else that isn't listed under the issues!