NuCivic / data-openFDA

Open Data Portal for open.fda.gov
http://openfda.nucivic.build/
GNU General Public License v2.0
0 stars 1 forks source link

Charts don't render in Safari #14

Open andrewhoppin opened 9 years ago

andrewhoppin commented 9 years ago

This chart looks great in Chrome, but not showing up in Safari:

http://openfda.nucivic.build/dataset/devices-enforcement-reports/resource/73d7e737-4a50-4cac-ade5-8985b2f57e0d

andrewhoppin commented 9 years ago

We're not required to support all browsers in this prototype, so this could be set to wontfix. A warning at the top of pages to recommend Chrome would be nice though.

andrewhoppin commented 9 years ago

related, @acouch notes in Slack that Safari is the new IE: https://nucivic.slack.com/archives/temp-gsa-18f/p1436208626000468 (cite: http://nolanlawson.com/2015/06/30/safari-is-the-new-ie/)

andrewhoppin commented 9 years ago

@jacintocapote could you please see if there is a simple way to post this message on pages that have Charts (or all pages)? "This prototype is optimized for viewing with the Chrome web browser. Please use Chrome in order to experience the full prototype."

jacintocapote commented 9 years ago

I added via panels see here http://openfda.nucivic.build/dataset/devices-adverse-events/resource/c76a816a-4842-442e-922f-4795f1dc04e4

andrewhoppin commented 9 years ago

thanks @jacintocapote ; visually quite large though; could you make it smaller?

shrink
andrewhoppin commented 9 years ago

@jacintocapote @acouch I thought that the dataset Charts had a problem rendering only in Safari and not in Chrome, but I’m testing on Chrome on iOS and they don’t render there either... However, http://nucivic.github.io/nvd3_visualization_app/view.html#{model:{backend:!csv,url:!http://demo.getdkan.com/sites/default/files/us_foreclosures_jan_2012_by_state_0.csv},seriesFields:[!total.foreclosures,!foreclosure.ratio],xDataType:!Auto,options:{x:!state,xAxis:{rotateLabels:!,axisLabel:!},yAxis:{axisLabel:!,axisLabelDistance:0},tooltips:false,showControls:false,showLegend:false,reduceXTicks:true,margin:{top:15,right:10,bottom:50,left:60}},graphType:!discreteBarChart,group:true} does work in Chrome on iOS, so it is likely a problem with the implementation in the prototype, not the tool. @jacintocapote could you pls take a look in the AM?

andrewhoppin commented 9 years ago

Also @jacintocapote, this isn't worth more than 30 minutes of work, but the "use Chrome" warning wouldn't show up for people that ARE using Chrome browsers.

jacintocapote commented 9 years ago

See now and is showed all browsers except Chrome.