search

NuCivic / dkan-ebola

http://eboladata.org
GNU General Public License v2.0
1 stars 1 forks source link

Dataset node edit accordian field options not working #28

Closed andrewhoppin closed 9 years ago

andrewhoppin commented 9 years ago

![authoring_options] menus

see attached.... can't expand or contract field option menus

acouch commented 9 years ago

I'm not seeing this on the demo site so don't think it is release specific.

andrewhoppin commented 9 years ago

I don't see accordian menus on demo.getdkan.com at all. Why would EbolaData.org have them? My concern (other than fixing EbolaData.org) is that other live DKAN sites, when upgrading to 1.7, might experience similar issues, even if our own testing on demo.getdkan.com come out clean...

jonpugh commented 9 years ago

Looks like something Javascript is breaking, preventing the expanding fieldsets.

Could also be the cause of #30...

Found the cuprit: 

http://eboladata.org/profiles/dkan/libraries/Leaflet/dist/leaflet-src.js?v=6 Failed to load resource: the server responded with a status of 404 (Not Found)
jonpugh commented 9 years ago

Was wondering why that JS file wasn't

Turns out it was gitignore in the leaflet library.

The following paths are ignored by one of your .gitignore files:
profiles/dkan/libraries/Leaflet/dist/leaflet-src.js

@drkloc we need a good way of dealing with these .gitignores...

jonpugh commented 9 years ago

Ok, the file was deployed making the fieldsets change into vertical tabs fieldsets.

@acouch The problem was that leaflet was set to gitignore it's own dist/leaflet-src.js file, so when I copied down the new release, it was never added to the eboladata.org git repo.

I need to flag this somewhere with the DKAN team, there are a lot of libraries and gitignore files out there that make it hard to update a site.

jonpugh commented 9 years ago

Waiiit i i think i know the problem. I was just looking at NuCivic/data_starter's Leaflet directory and I am not seeing a .gitignore.

It must have been left over from the original eboladata.org.

@acouch should we add something about this to the DKAN release notes?