NuGet / Home

Repo for NuGet Client issues
Other
1.5k stars 252 forks source link

Powershell init.ps1 doesn't run correctly for EF6 if you downgrade and then upgrade #10091

Open erdembayar opened 4 years ago

erdembayar commented 4 years ago

Detailed repro steps so we can see the same problem

  1. Let there is solution installed EF V6.3

  2. Downgrade to EF FV6.1

  3. Then upgrade to EF 6.4.4

Now if type "update-database" on PMC then you'll get error A version of Entity Framework older than 6.3 is also installed. The newer tools are running. Use 'EntityFramework\Update-Database' for the older version. It looks like if you downgrade/upgrade EF then init.ps1 doesn't run properly is causing this problem.

image.png

nkolev92 commented 4 years ago

It looks like if you downgrade/upgrade EF then init.ps1 doesn't run properly is causing this problem.

Do you actually know whether init.ps1 is being? Or did you conclude this by observing the symptoms?

erdembayar commented 4 years ago

@nkolev92 I did debugging and discovered one no-Op check condition was preventing re-run init.ps1.

nkolev92 commented 4 years ago

You should leave a code pointer to make it easier for the implementer if this becomes a high priority.

I imagine you can repro the above by just downgrading to 6.1, is that correct? We might need to retitle the issue.

erdembayar commented 4 years ago

Removing "Perf" label since it's not really stressing performance, it's just bug. Maybe we can move to "Ice box" because no one is complaining, now I understand powershell more than before. It's already not perfect thing, actually it's best to restart VS this situation because we already import different .psm1 files which is polluting powershell, same time we can't un-import/remove what is already imported from powershell.

nkolev92 commented 4 years ago

I'm not restart VS should ever be a guidance that's consider ok unless in really exceptional circumstasnces, but I agree with your assessment about the priority. Not high priority at this point.