The Nuget upgrade utility for packages.config has a hardcoded list of 3 project types

vsfeedback commented 2 years ago

This issue has been moved from a ticket on Developer Community.

[severity:It bothers me. A fix would be nice] The Nuget upgrade utility for packages.config has a hardcoded list of 3 project types that are allowed to update.

See https://github.com/NuGet/NuGet.Client/blob/631411c00f0fd494d05c77f8751b67570737d791/src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Utility/NuGetProjectUpgradeUtility.cs#L108

The UpgradeableProjectTypes are declared as (see https://github.com/NuGet/NuGet.Client/blob/631411c00f0fd494d05c77f8751b67570737d791/src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Utility/NuGetProjectUpgradeUtility.cs#L22)

new HashSet(StringComparer.OrdinalIgnoreCase)
            {
                VsProjectTypes.CsharpProjectTypeGuid,
                VsProjectTypes.VbProjectTypeGuid,
                VsProjectTypes.FsharpProjectTypeGuid
            };

This means that other project types, even when they support all the necessary interfaces will not be allowed to upgrade. For now we have worked around this by checking (in the project.Kind property) if we are being called from NuGet (by checking for the string "NuGet" in the StackTrace) and then return the CsharpProjectTypeGuid, but that is a real kludge. This is simply a bad design. The utility should not check the project Kind in a fixed list but should check if the project implements VSProject4. If that is the case then it should allow the upgrade to happen. I can imagine that there is a list of project types that you do NOT want to support, but to limit the support to only these 3 types is really not OK.