PM UI: should not recommend deprecated packages

dtivel commented 1 year ago

NuGet Product Used

Visual Studio Package Management UI

Product Version

VS 17.7.0 Preview 2.0 [33729.141.main]

Worked before?

No response

Impact

It bothers me. A fix would be nice

Repro Steps & Context

I'm not sure how to provide repro steps for NuGet package recommender.

That said, I opened PM UI, and the Browse tab displayed a deprecated package as recommended.

Not sure if the recommendation should not be made at all or if it should be behind a "Show deprecated packages" option, but it seems like a bad idea to recommend deprecated packages.

Verbose Logs

Microsoft Visual Studio Enterprise 2022
Version 17.7.0 Preview 2.0 [33729.141.main]
VisualStudio.17.IntPreview/17.7.0-pre.2.0+33729.141.main
Microsoft .NET Framework
Version 4.8.04084

Installed Version: Enterprise

Visual C++ 2022   00476-80000-00000-AA281
Microsoft Visual C++ 2022

ASP.NET and Web Tools   17.7.137.65386
ASP.NET and Web Tools

Azure App Service Tools v3.0.0   17.7.137.65386
Azure App Service Tools v3.0.0

Azure Functions and Web Jobs Tools   17.7.137.65386
Azure Functions and Web Jobs Tools

C# Tools   4.7.0-2.23274.2+2b33f51dabed9c603211996922e05fd762f72b00
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Common Azure Tools   1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

Extensibility Message Bus   1.4.32 (main@0bf34d7)
Provides common messaging-based MEF services for loosely coupled Visual Studio extension components communication and integration.

Microsoft Azure Tools for Visual Studio   2.9
Support for Azure Cloud Services projects

Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines

Mono Debugging for Visual Studio   17.7.16 (be7117c)
Support for debugging Mono processes with Visual Studio.

NuGet Package Manager   6.7.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/

Razor (ASP.NET Core)   17.7.2.2327203+0d2016668eddd10f9760af81b193e20a7e0b849c
Provides languages services for ASP.NET Core Razor.

SQL Server Data Tools   17.7.1.0
Microsoft SQL Server Data Tools

Syntax Visualizer   1.0
An extension for visualizing Roslyn SyntaxTrees.

Test Adapter for Boost.Test   1.0
Enables Visual Studio's testing tools with unit tests written for Boost.Test.  The use terms and Third Party Notices are available in the extension installation directory.

Test Adapter for Google Test   1.0
Enables Visual Studio's testing tools with unit tests written for Google Test.  The use terms and Third Party Notices are available in the extension installation directory.

TypeScript Tools   17.0.20517.2001
TypeScript Tools for Microsoft Visual Studio

Visual Basic Tools   4.7.0-2.23274.2+2b33f51dabed9c603211996922e05fd762f72b00
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Visual F# Tools   17.7.0-beta.23272.3+96bfa24a5fee6722ed3e2b280d37e80b594bbcf4
Microsoft Visual F# Tools

VisualStudio.DeviceLog   1.0
Information about my package

VisualStudio.Mac   1.0
Mac Extension for Visual Studio

VSPackage Extension   1.0
VSPackage Visual Studio Extension Detailed Info

Xamarin   17.7.0.109 (main@9a10b8b)
Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.

Xamarin Designer   17.7.2.3 (remotes/origin/main@da9f0716d6)
Visual Studio extension to enable Xamarin Designer tools in Visual Studio.

Xamarin Templates   17.7.17 (95eb8d3)
Templates for building iOS, Android, and Windows apps with Xamarin and Xamarin.Forms.

Xamarin.Android SDK   13.2.0.11 (d17-5/b372b80)
Xamarin.Android Reference Assemblies and MSBuild support.
    Mono: 6dd9def
    Java.Interop: xamarin/java.interop/d17-5@149d70fe
    SQLite: xamarin/sqlite/3.40.1@68c69d8
    Xamarin.Android Tools: xamarin/xamarin-android-tools/d17-5@ca1552d

Xamarin.iOS and Xamarin.Mac SDK   16.4.0.5 (191fe02ea)
Xamarin.iOS and Xamarin.Mac Reference Assemblies and MSBuild support.

nkolev92 commented 1 year ago

Created an internal issue.

nkolev92 commented 1 year ago

An idea would also be to filter out the deprecated packages client side.

This might cause a flicker due to timing issues, so something to test out.

NuGet / Home