search

NuGet / Home

Repo for NuGet Client issues
Other
1.49k stars 250 forks source link

Wrong documentation in Create UWP package (C#) #13586

Closed HO-COOH closed 3 weeks ago

HO-COOH commented 2 months ago

NuGet Product Used

NuGet.exe

Product Version

N/A

Worked before?

No response

Impact

It bothers me. A fix would be nice

Repro Steps & Context

Link here

Obviously, you are not packaging any dll files in the nuspec file image

But in the result screenshot, there are dll files out of nowhere image

I get redirected by this

Verbose Logs

No response

jgonz120 commented 2 months ago

The DLLs in that screenshot are for the package which is being packed. One for each of the targeted runtimes supported. These DLLs are necessary for users to be able to use the package. Is there a different result you were expecting?

zivkan commented 2 months ago

@jgonz120 the first screenshot shows the nuspec includig .winmd files, not .dll. The .dll assemblies will only work (maybe?) for .NET UWP apps, but .winmd will work for both .NET and also C++ UWP apps.

jgonz120 commented 2 months ago

@zivkan oh, I assumed because the other packages include the DLLs without specifying them in the nuspec they were meant to show up. Now that I followed the tutorial, I'm no longer seeing the DLLs: image

So we should just update the doc?

zivkan commented 2 months ago

It was originally reported in the docs repo, but because the docs team were planning to turn off issues in the docs repo (which they have done since then), they instructed people to re-create the issues here (and the docs person, I think his account name is something like mikejo5000) created a bunch here.

We don't have a new issue template for docs, hence why all the docs issues that were recreated in home were created with the bug template.

HO-COOH commented 2 months ago

So, can anyone direct me to the right place to file documentation issue? I have a bunch of others I want to raise. I don't want to use the feedback link, because I want to track the updates. And I think the feedback just get mostly ignored anyways.

zivkan commented 2 months ago

All the docs pages on learn.microsoft.com have feedback buttons at the top and bottom of the page. However, I'm confident it's not public, so you won't' be able to track them.

HO-COOH commented 2 months ago

All the docs pages on learn.microsoft.com have feedback buttons at the top and bottom of the page. However, I'm confident it's not public, so you won't' be able to track them.

That does not answer my question tho. I want to know if this is the correct place to file documentation issues.

donnie-msft commented 1 month ago

All the docs pages on learn.microsoft.com have feedback buttons at the top and bottom of the page. However, I'm confident it's not public, so you won't' be able to track them.

That does not answer my question tho. I want to know if this is the correct place to file documentation issues.

I had to find out myself, as this process changed in recent days. No, please do not file docs issues in the Home repo. Instead, on any docs page, use the Thumbs Down button and provide the detail in the form that appears. The feedback for docs is recorded from that point. /cc @Mikejo5000

Product issues are still to be filed here on GitHub.

dotnet-policy-service[bot] commented 1 month ago

This issue has been automatically marked as stale because we have not received a response in 14 days. It will be closed if no further activity occurs within another 14 days of this comment.