VS restore won't respect project prefix in the lock file

[martinrrm]

Internal ticket: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2172224

This is a weird bug, when you are using lock files and have a ProjectA referencing ProjectB and add a prefix in the Directory.Build.props with a PackageReference to Nugetizer, the lock file is going to produce different outputs depending on where restore was made.

VS will output something like this:

{
  "version": 1,
  "dependencies": {
    "net8.0": {
      "referencedproject": {
        "type": "Project"
      }
    }
  }
}

While doing a dotnet restore it will result in:

{
  "version": 1,
  "dependencies": {
    "net8.0": {
      "A.Prefix.ReferencedProject": {
        "type": "Project"
      }
    }
  }
}

Example Directory.Build.props:

<Project>
  <PropertyGroup>
    <LangVersion>latest</LangVersion>
    <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>

    <AssemblyPreffix Condition="$(AssemblyPreffix) == ''">A.Prefix</AssemblyPreffix>
    <AssemblyName Condition="$(AssemblyName) == ''">$(MSBuildProjectName)</AssemblyName>
    <AssemblyName Condition="!$(AssemblyName.StartsWith(AssemblyPreffix))">$(AssemblyPreffix).$(AssemblyName)</AssemblyName>
  </PropertyGroup>

  <ItemGroup Condition="!$(MSBuildProjectName.Contains('ReferencedProject'))">
    <ProjectReference Include="..\ReferencedProject\ReferencedProject.csproj" />
  </ItemGroup>
</Project>

Example ReferencedProject.csproj:

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net8.0</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="NuGetizer" Version="*">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
    </PackageReference>
  </ItemGroup>
</Project>

[dotnet-policy-service[bot]]

@martinrrm Issue is missing Type label, remember to add a Type label

[nkolev92]

Assigning to hotseat for investigation

[jebriede]

Team Triage: Assigning to current hotseat for investigation

[kartheekp-ms]

I am able to reproduce this issue in VS 2022 versions 17.11.2, 17.12 public preview, and internal preview.

I noticed an odd behavior, but I haven't identified the root cause yet.

• Cloned the repo https://github.com/voroninp/BadRestore locally
• The project name in https://github.com/voroninp/BadRestore/blob/17c6cef9243543d6c854418d23913bfe2b29ea80/BadRestore/packages.lock.json#L5 is still referencedproject
• Opened BadRestore.sln in Visual Studio 2022
• I observed that the project name was A.Prefix.Referencedproject for a fraction of a second before it changed to referencedproject. I didn't execute dotnet restore in separate process.

[jeffkl]

@voroninp I believe the repro has bad MSBuild syntax which I've fixed at https://github.com/voroninp/BadRestore/pull/1 and now the lock file is properly regenerated in VS for me.

[voroninp]

@jeffkl , hi, I'll be able to check in a week. Thanks.