NuGet / Home

Repo for NuGet Client issues
Other
1.5k stars 252 forks source link

There is no PM UI horizontal scroll when the width is not enough to display all controls #13892

Open v-luzh opened 2 weeks ago

v-luzh commented 2 weeks ago

NuGet Product Used

Visual Studio Package Management UI

Product Version

Dev\6.13.0.46

Worked before?

It is a regression since it didn't repro on Dev\6.13.0.45.

Impact

It bothers me. A fix would be nice

Repro Steps & Context

Details about problem

NuGet Version: Dev\6.13.0.46 VS Version: Main\35429.116 OS: Windows-11-Enterprise-23H2

Notes:

  1. Repro rate: 100%
  2. It starts to repro from NuGet Client Dev\6.13.0.46, doesn’t repro on NuGet Client Dev\6.13.0.45.

Repro Steps:

  1. Create a new C# Console App (.NET 9.0) project in VS and open it in full-screen VS Internal Preview. 
  2. Click menu “Tools -> NuGet Package Manager -> Manage NuGet Packages for Solution”. 
  3. Start shrinking width of VS Internal Preview window and observe the bottom of the PM UI.

    Expected Result:

    There should be PM UI horizontal scroll when the width is not enough to display all controls.

Actual Result:

There is no PM UI horizontal scroll when the width is not enough to display all controls as the screenshot below. image

donnie-msft commented 2 weeks ago

Nice catch!

I believe this is due to the layout changes that were made with the new README tabs. It appears that the README tab itself has a ScrollViewer, so the parent's ScrollViewer is no longer in play.

I think the horizontal scrolling still makes sense at a certain point rather than allowing controls to squish to 0. Some may not like our original duplicate scrollbars, but at a certain threshold, I think full-panel scrolling is better.

I verified this does not repro Version 17.13.0 Preview 1.0 [35427.47.main] image

By the way, it's not relevant to the license disclaimer being open/closed.

After dismissing the license disclaimer: image

nkolev92 commented 1 week ago

Team Triage; Assigning to @jgonz120 since this is a regression in the active release.