nuget.exe pack with both -symbols and -suffix give incorrect name to symbol package

joelverhagen commented 8 years ago

Steps

Create a .nuspec on disk.
Make sure there are some files to pack (nuget.exe pack won't make an empty package).
Run nuget.exe pack path\to\my.nuspec -symbols -suffix beta
Expected

Two nupkgs, one ending in beta.nupkg and the other ending in beta.symbols.nupkg.

Actual

The symbols package's file name has the version number without the suffix. The .nuspec inside the package seems fine though.

Example

nuget.exe pack VS.Redist.NuGet_VS15.nuspec -symbols -suffix BETA

Attempting to build package from 'VS.Redist.NuGet_VS15.nuspec'.
Successfully created package 'C:\Users\jver\Desktop\foo\VS.Redist.NuGet_VS15.3.5.160923.1438-BETA.nupkg'.
Successfully created package 'C:\Users\jver\Desktop\foo\VS.Redist.NuGet_VS15.3.5.160923.1438-bar.symbols.nupkg'.

Tried on latest dev and 3.5.0-rc1.

atifaziz commented 7 years ago

I can confirm the same using NuGet 4.3.0.4406. Fortunately, the <version> element in the symbols package does have the suffix so the workaround is just to rename the symbols file and add the suffix manually.

Considering tomorrow is this issue's first anniversary, it would be nice to get an ETA as a gift. 😄

atifaziz commented 7 years ago

so the workaround is just to rename the symbols file and add the suffix manually.

Another workaround is to use a replacement token, like so:

<version>1.0.0$VersionSuffix$</version>

And then instead of using -Suffix, use -Properties VersionSuffix=-beta1.

jainaashish commented 7 years ago

This isn't a high priority item for now and besides there are easy workarounds available. So will mark it for upforgrab.

ferarias commented 6 years ago

Ok it's not prioritary since there are workarounds, but it's a malfunction anyway. Solving using @atifaziz second workaround.

ferarias commented 6 years ago

This issue is still active. This is a friendly "bump"

sharpSteff commented 5 years ago

"bumb"

NuGet / Home