search

NuGet / Home

Repo for NuGet Client issues
Other
1.5k stars 252 forks source link

PackageReference - Should Project File be autosaved after nuget operations #6013

Open bradphelan opened 7 years ago

bradphelan commented 7 years ago

Details about Problem

I selected a nuget package to update. After it is finished the UI still says the package is at the old version. I look on the filesystem and the PackageReferences are still at the old version. I then click save all and all the project files are updated.

I assume that the system forgets to do a save all after doing the nuget update.

Microsoft Visual Studio Professional 2017 
Version 15.3.5
VisualStudio.15.Release/15.3.5+26730.16
Microsoft .NET Framework
Version 4.7.02046

Installed Version: Professional

Visual Basic 2017   00370-10200-08842-AA207
Microsoft Visual Basic 2017

Visual C# 2017   00370-10200-08842-AA207
Microsoft Visual C# 2017

Visual C++ 2017   00370-10200-08842-AA207
Microsoft Visual C++ 2017

Visual F# 4.1   00370-10200-08842-AA207
Microsoft Visual F# 4.1

Application Insights Tools for Visual Studio Package   8.8.00712.1
Application Insights Tools for Visual Studio

ASP.NET and Web Tools 2017   15.0.30726.0
ASP.NET and Web Tools 2017

ASP.NET Core Razor Language Services   1.0
Provides languages services for ASP.NET Core Razor.

ASP.NET Template Engine 2017   15.0.30726.0
ASP.NET Template Engine 2017

ASP.NET Web Frameworks and Tools 2017   5.2.50601.0
For additional information, visit https://www.asp.net/

Azure App Service Tools v3.0.0   15.0.30728.0
Azure App Service Tools v3.0.0

Common Azure Tools   1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

EditProj   1.0
This packages allows you to edit project files without the need to unload them first.

JavaScript Language Service   2.0
JavaScript Language Service

JetBrains ReSharper Ultimate 2017.2    Build 109.0.20170824.131346
JetBrains ReSharper Ultimate package for Microsoft Visual Studio. For more information about ReSharper Ultimate, visit http://www.jetbrains.com/resharper. Copyright © 2017 JetBrains, Inc.

JustDecompilePackage2017 Extension   1.0
JustDecompilePackage2017 Visual Studio Extension Detailed Info

Microsoft Azure Tools   2.9
Microsoft Azure Tools for Microsoft Visual Studio 2017 - v2.9.50719.1

Microsoft Continuous Delivery Tools for Visual Studio   0.3
Simplifying the configuration of continuous build integration and continuous build delivery from within the Visual Studio IDE.

Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines

Microsoft MI-Based Debugger   1.0
Provides support for connecting Visual Studio to MI compatible debuggers

Microsoft Visual C++ Wizards   1.0
Microsoft Visual C++ Wizards

Multilingual App Toolkit   4.0
Multilingual App Toolkit helps you localize your Windows Store app by providing file management, pseudo and machine translation, translation editor, and build integration. http://aka.ms/matinstall

NuGet Package Manager   4.3.1
NuGet Package Manager in Visual Studio. For more information about NuGet, visit http://docs.nuget.org/.

Project File Tools   1.0.1
Provides Intellisense and other tooling for XML based project files such as .csproj and .vbproj files.

SQL Server Data Tools   15.1.61707.200
Microsoft SQL Server Data Tools

TargetFrameworkMigrator   1.0
Bulk Change .Net Projects Target Frameworks

TypeScript   2.3.4.0
TypeScript tools for Visual Studio

Visual Studio Code Debug Adapter Host Package   1.0
Interop layer for hosting Visual Studio Code debug adapters in Visual Studio

VSColorOutput   2.5.1
Color output for build and debug windows - http://mike-ward.net/vscoloroutput

VsVim   2.4.1.0
VsVim is a Vim emulator for Visual Studio

WebJobs Tools v1.0.0   15.0.30901.0
WebJobs Tools v1.0.0
rohit21agrawal commented 7 years ago

@bradphelan what kind of project are you encountering this with?

bradphelan commented 7 years ago

its a large project. about 30 sub projects. most are new SDK type projects targetting net461 and there are two fsharp projects in there. might be one old style csproj file but i am sure i converted everything.

On Thu, 12 Oct 2017, 01:53 Rohit Agrawal notifications@github.com wrote:

@bradphelan https://github.com/bradphelan what kind of project are you encountering this with?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NuGet/Home/issues/6013#issuecomment-335980849, or mute the thread https://github.com/notifications/unsubscribe-auth/AABE8rAkqOqj_o0AbBwDEl4TqykyEoHaks5srVUEgaJpZM4P07nY .

bradphelan commented 7 years ago

This may or may not be related. After consolidation is finished

image

It still says there is something to be consolidated even though there is nothing in the list.

bradphelan commented 7 years ago

No it doesn't. It's just a UI glitch. If I change tabs and then back again then the blue 1 is gone.

image

eroller commented 6 years ago

I can confirm the original bug report (project files are not saved after nuget update) and also the UI glitch for Consolidate tab. Please fix these.

rrelyea commented 5 years ago

@donnie-msft and i were walking through the scenario matrix...not done yet:

add a new class csproj.dll - doesn't auto save project. sdk style - doesn't need to save project

add ref to binary csproj.dll - doesn't auto save project. sdk style - doesn't auto save project.

installing package csproj.dll + PC - saves the project csproj.dll + PR - via pmc - csproj.dll + PR - via pmui- restores, but doesn't save proj sdk style - via hand edit csproj - doesn't restore until you save proj sdk style - via pmc - restores, but doesn't save proj sdk style - via pmui- restores, but doesn't save proj

uninstalling package sdk style - via pmc - restores immediately, but doesn't save csproj

upgrading package csproj.dll + PC - saves the project

related? #7241

nkolev92 commented 2 years ago

Triage: We should verify whether this is still happening. If it is still happening, we think it should be saved.