Open nkolev92 opened 6 years ago
The majority of the removal is done in https://github.com/NuGet/NuGet.Client/tree/dev-nkolev92-cleanupPackageSpecRunTests.
The concern here is that some scenarios would be removed. (Specifically nuget.exe project.json pack). The flip side is that those scenarios never RTM'd.
Draft PR in https://github.com/NuGet/NuGet.Client/pull/2784.
The PackageSpec model currently has a bunch of redundant APIs.
Among those IncludeExcludeFiles, PackOptions, PackInclude etc.
These need to be removed if they are not used anymore.
Likewise a similar analysis needs to be done on rest of the package spec.
Related discussion here
//cc @emgarten @rohit21agrawal