Clean up Package Spec redudant APIs

NuGet / Home

Repo for NuGet Client issues

Other

1.49k stars 250 forks source link

Clean up Package Spec redudant APIs #6231

Open nkolev92 opened 6 years ago

nkolev92 commented 6 years ago

The PackageSpec model currently has a bunch of redundant APIs.

Among those IncludeExcludeFiles, PackOptions, PackInclude etc.

These need to be removed if they are not used anymore.

Likewise a similar analysis needs to be done on rest of the package spec.

Related discussion here

//cc @emgarten @rohit21agrawal

nkolev92 commented 5 years ago

The majority of the removal is done in https://github.com/NuGet/NuGet.Client/tree/dev-nkolev92-cleanupPackageSpecRunTests.

The concern here is that some scenarios would be removed. (Specifically nuget.exe project.json pack). The flip side is that those scenarios never RTM'd.

nkolev92 commented 5 years ago

Draft PR in https://github.com/NuGet/NuGet.Client/pull/2784.