Open clairernovotny opened 6 years ago
Currently BuildSigningCertificateChainOnce() and Chain are internal. That makes it hard for external signature providers to use the same logic as the X509SingatureProvider here:
BuildSigningCertificateChainOnce()
Chain
X509SingatureProvider
https://github.com/NuGet/NuGet.Client/blob/8f7a9c170521fd60353db5ebc2661cae5f663c1b/src/NuGet.Core/NuGet.Packaging/Signing/Authoring/X509SignatureProvider.cs#L113-L120
Please make these methods public and ensure that the methods used by the built-in signature providers are not internal.
/cc @dtivel
@dtivel @mishra14 @zhili1208 @PatoBeltran
Currently
BuildSigningCertificateChainOnce()
andChain
are internal. That makes it hard for external signature providers to use the same logic as theX509SingatureProvider
here:https://github.com/NuGet/NuGet.Client/blob/8f7a9c170521fd60353db5ebc2661cae5f663c1b/src/NuGet.Core/NuGet.Packaging/Signing/Authoring/X509SignatureProvider.cs#L113-L120
Please make these methods public and ensure that the methods used by the built-in signature providers are not internal.
/cc @dtivel