search

NuGet / Home

Repo for NuGet Client issues
Other
1.49k stars 252 forks source link

Migrator dogfooding issues #6666

Closed karann-msft closed 6 years ago

karann-msft commented 6 years ago

  1. typo in gold bar [FIXED] image

  2. gold bar should have an info icon [CUT] image

  3. gold bar should have a close "X" at the end [FIXED] image

    Compare with other gold bars in the product image

  4. Package issues messages need to be rephrased [OPEN]

    • "install.ps1" script will be ignored when the package is installed after the migration
    • "content" assets will not be available when the package is installed after the migration
    • XDT transforms will not be applied when the package is installed after the upgrade
    • "lib\foo.dll" will be ignored when the package is installed after the migration

  5. Migration report must open in the browser and not in VS [OPEN]

  6. Only one backup folder should be created. [KINDA FIXED] image

  7. Rename the report file - NuGetMigrationLog. Also, ensure it reflects in the page title that shows up on the browser tab [OPEN] image

  8. Update the text and link for revert the migration. [OPEN] Text - Help me rollback to packages.config URL - https://aka.ms/nuget-pc2pr-migrator-rollback

  9. Clicking on the link to the backup should open the backup folder [OPEN]

  10. Small nits in the report headings [OPEN]

    • Packages Processed -> Packages processed
    • Top-level Dependencies -> Top-level dependencies
    • Transitive Dependencies -> Transitive dependencies
rohit21agrawal commented 6 years ago

About the backup folder, the addition of guid prefix has been done to avoid accidentally deleting user data as Backup is a very generic folder name. I don't think creating multiple backup folders should be too big of an issue.

karann-msft commented 6 years ago

Rename the folder to "migration backup" or something more exotic if that's your concern. At the very least, remember the folder you created since you know that there would be no user data in that and use that for subsequent migrations. In my opinion, change the folder name and call it good unless we are using this as a workaround for some other issue.

karann-msft commented 6 years ago

Reopening since some issues haven't been addressed.

rohit21agrawal commented 6 years ago

@karann-msft please tell which issues haven't been addressed?

karann-msft commented 6 years ago

I have tagged all the issues listed above. Everything with [OPEN] needs to be addressed. As and when you fix them, change the associated tags.

rrelyea commented 6 years ago

@rohit21agrawal - seems like we should fix any of these needed for 15.7 this week.

rohit21agrawal commented 6 years ago

@karann-msft can you show me where you see NuGet Upgrade Report in the migrator report? it's already been fixed

rohit21agrawal commented 6 years ago

same for item # 10 & 8 . Please send me screenshots if you still see the issue.

rohit21agrawal commented 6 years ago

number 9 cannot be done for security reasons : https://stackoverflow.com/questions/18246053/how-can-i-create-a-link-to-a-local-file-on-a-locally-run-web-page/18246357#18246357