NuGet / Home

Repo for NuGet Client issues
Other
1.5k stars 252 forks source link

Updating package ‘EntityFramework’ need to restart VS for 3 times #8928

Closed v-luzh closed 7 months ago

v-luzh commented 4 years ago

Details about Problem

NuGet version: NuGet Client Dev\5.5.0.6346 VS Version: Master\29612.110 OS: Windows-10-Enterprise-RS5

Detailed repro steps

  1. Launch VS and click “Create a New Project” button.
  2. Create an ASP.NET Web Application (.NET Framework) project (Single Page Application).
  3. Open PM UI of this project and go to ‘Update’ tab.
  4. Select all packages and click ‘Update’ button.

    Expected

    Updating package ‘EntityFramework’ from version 6.2.0 to 6.4.0 need to restart VS for only 1 time.

    Actual

    Updating package ‘EntityFramework’ from version 6.2.0 to 6.4.0 need to restart VS for 3 times as below screenshot. That’s boring to restart VS just for uninstalling the same package ‘EntityFramework.6.2.0’. ThreeTimeRestartRequest

    Note

    It didn’t repro on 16.5 Preview1: D16.5\29521.150 (with implicit NuGet Client 5.5.0.6293)

v-luzh commented 4 years ago

Only one-time restart request repro on Master\29619.96+NuGet Client Dev\5.5.0.6353. Got the log from handle.exe as below. image

PS C:\Users\v-luzh\Desktop\Handle> .\handle.exe -a "C:\Users\v-luzh\source\repos\WebSinglePage\packages\EntityFramework.6.2.0\tools\EntityFramework.PowerShell.Utility.dll"

Nthandle v4.22 - Handle viewer Copyright (C) 1997-2019 Mark Russinovich Sysinternals - www.sysinternals.com

devenv.exe pid: 14520 type: File 2084: C:\Users\v-luzh\source\repos\WebSinglePage\packages\EntityFramework.6.2.0\tools\EntityFramework.PowerShell.Utility.dll

heng-liu commented 4 years ago

Hi @v-luzh, is this a regression? I tried but could not repro on 16.5 Preview4 (restarted only 1 time). But I'm not sure if it's fixed on 16.5 Preview4. Could you help to repro on 16.5 Preview4, to see if it still exists? Thanks!

heng-liu commented 4 years ago

Hi @v-luzh, to be more accurate, can you help to repro on latest VS version in rel/d16.5? Thanks!

heng-liu commented 4 years ago

Close it as couldn't repro on 16.5 Preview4. Pls reopen it if you can still repro. Thanks!

v-luzh commented 4 years ago

Hi @heng-liu, sorry, just saw your message since I didn't get your update comments in my mail-reminder. I can repro this bug on D16.5 GA (D16.5\29905.175)--asked to restart twice. Please help to reactivate it, thanks.

heng-liu commented 4 years ago

Hi @v-luzh , I just tried twice the following steps, but could not repro. (only 1 restart is required) May I know if I miss anything in the repro? Or can you pls provide the detailed repro steps? Thanks!

  1. Launch VS16.5.0 Preview 6.0 [29905.175.d16.5]

image

  1. Create a new ASP.NET web application(.NET Framework) project image
  2. Choose Single Page Application image
  3. Open PM UI of this project and go to ‘Update’ tab, select all packages and click ‘Update’ button. image
  4. Finish all the updates and click the restart image
  5. Open the PM UI, and no restart is required anymore image
v-luzh commented 4 years ago

Hi @heng-liu, you can see the second-time restart request (as below screenshot) in PM Console in your step6. image

heng-liu commented 4 years ago

Hi @v-luzh thanks for your reply! I'm able to repro now :) This is after updating all the packages, before the first restart image If I click the restart button on the top, after the first restart, I could not found any restart request in my repro.. image If I click the restart button on the bottom(in PMC), then after restart, there will be another restart request in PMC. So in your repro, you click the restart in PMC, right? Thanks!

v-luzh commented 4 years ago

Hi @heng-liu, yes, that's how I repro this issue. Please have a look, thanks,

heng-liu commented 4 years ago

It doesn't repro on ASP.NET .netcore. Only repro for ASP.NET .netframework. And after clicking restart in PMC for two times, it goes back to normal. So it doesn't affect any operation after it.

v-luzh commented 7 months ago

Closing this bug since it is fixed on VS Main\34807.21 + NuGet Client Dev\6.11.0.9.