search

NuGet / NuGet.Build.Packaging

The NuGetizer-3000 is here!
Other
70 stars 28 forks source link

Added baseNuspecFile support and removed duplicate files exception #149

Closed thorgeir closed 7 years ago

thorgeir commented 7 years ago

Added support to base the nuget package of an existing nuspec file. This was possible in the NuProj projects and I've duplicated the behavior.

Also I've removed the duplicate file exception. The _PackageContent variable will contain duplicate file references when one or more project references the same files/assemblies, this should not cause an exception. Instead the duplicates are removed and the first reference is used.

dnfclas commented 7 years ago

@thorgeir, Thanks for your contribution. To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.

It will cover your contributions to all .NET Foundation-managed open source projects. Thanks, .NET Foundation Pull Request Bot

kzu commented 7 years ago

Could you please split the two in separate PRs for clarity and tracking purposes? That will make it easier to also discuss each one separately.

Thanks!

dnfclas commented 7 years ago

@thorgeir, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, .NET Foundation Pull Request Bot