search

NuGet / NuGetGallery

NuGet Gallery is a package repository that powers https://www.nuget.org. Use this repo for reporting NuGet.org issues.
https://www.nuget.org/
Apache License 2.0
1.52k stars 643 forks source link

Remove elmah table usage from gallery #10021

Closed drewgillies closed 1 day ago

drewgillies commented 1 week ago

Partially addresses: https://github.com/NuGet/Engineering/issues/5480

We'll remove this table's usage as a part of the SDK migration effort.

drewgillies commented 1 week ago

FYI @Lanaparezanin

joelverhagen commented 1 week ago

PR against dev please

joelverhagen commented 1 week ago

Love the clean-up!

agr commented 1 week ago

Should it include a change to admin index page to remove Elmah link?

erdembayar commented 2 days ago

I'm wondering why Elmah.dll was reintroduced to sign.thirdparty.props? Is it still used somewhere?

drewgillies commented 1 day ago

@erdembayar @joelverhagen the file being unsigned broke the build, and it persists in the build to support Elmah migrations (backward and, in future, forward [edit: correction--there was no backward migration to remove table/sprocs, and I doubt we'll add it--forward would be a good cleanup step though]). I will review this in separate work to see if it can be removed without removing migration support. See https://github.com/NuGet/Engineering/issues/5495 for tracking.