search

NuGet / NuGetGallery

NuGet Gallery is a package repository that powers https://www.nuget.org. Use this repo for reporting NuGet.org issues.
https://www.nuget.org/
Apache License 2.0
1.54k stars 643 forks source link

trim trailing whitespace #10040

Closed SimonCropp closed 3 months ago

SimonCropp commented 3 months ago

and update editorconfig

erdembayar commented 3 months ago

Thank you for this contribution. I think just changing the .editorconfig is enough for merging now. I don't think reviewing 318 files at once is good timing for us. This is more of an aesthetic change rather than a functional one, so we can do it as necessary over time.

erdembayar commented 3 months ago

Thank you for this contribution. I think just changing the .editorconfig is enough for merging now. I don't think reviewing 318 files at once is good timing for us. This is more of an aesthetic change rather than a functional one, so we can do it as necessary over time.

Thanks to @agr, realized I can easily review whitespace changes in Github. But need to wait little bit, there're large PR coming to merge, doesn't want to block that one with merge conflicts.

SimonCropp commented 3 months ago

no point continually chasing merge conflicts here. here is a new PR that just does the editor config https://github.com/NuGet/NuGetGallery/pull/10049

let me know if u ever want a full cleanup again