NuGet / NuGetGallery

NuGet Gallery is a package repository that powers https://www.nuget.org. Use this repo for reporting NuGet.org issues.
https://www.nuget.org/
Apache License 2.0
1.54k stars 644 forks source link

Adding https://skillicons.dev to trusted domains #10178

Open eventsourcer opened 1 week ago

eventsourcer commented 1 week ago

Allowing https://skillicons.dev icons to be rendered in readmes.

Examples

  1. https://skillicons.dev/icons?i=dotnet
  2. https://skillicons.dev/icons?i=docker
erdembayar commented 1 week ago

@lyndaidaii Could you please take a look into this?

eventsourcer commented 1 week ago

Also, is this happening for referenced images inside of readme? My I have an example referencing a packed image from readme?

erdembayar commented 5 days ago

Related issue: https://github.com/NuGet/Engineering/issues/5625

eventsourcer commented 5 days ago

Related issue: https://github.com/NuGet/Engineering/issues/5625

@erdembayar it's not found

erdembayar commented 5 days ago

Related issue: NuGet/Engineering#5625

@erdembayar it's not found

It's only for our internal ref.

eventsourcer commented 3 days ago

Related issue: NuGet/Engineering#5625

@erdembayar it's not found

It's only for our internal ref.

Any updates in this regard?