Improve API key v4 implementation based on internal feedback

NuGet / NuGetGallery

NuGet Gallery is a package repository that powers https://www.nuget.org. Use this repo for reporting NuGet.org issues.

https://www.nuget.org/

Apache License 2.0

1.55k stars 641 forks source link

Closed joelverhagen closed 1 month ago

joelverhagen commented 1 month ago

This is a non-breaking change.

Summary of changes:

Improve comments in ApiKeyV4
Use ToUpperInvariant instead of ToUpper (no need to be culture specific)
Use crypto random for 16 bytes instead of Guid.NewGuid().
- Technically this increases the entropy of the secret byte portion from 122 bits (per docs) to 128 bits.