search

NuGet / NuGetGallery

NuGet Gallery is a package repository that powers https://www.nuget.org. Use this repo for reporting NuGet.org issues.
https://www.nuget.org/
Apache License 2.0
1.55k stars 641 forks source link

Make license text part of sidebar license link #10246

Closed Goodyear2017 closed 1 week ago

Goodyear2017 commented 2 weeks ago

1.Accessibility Issue: AI4W reported packages page sidebar link "MIT" and surrounding text "license" having issue. image

  1. Fixed the issue by removing "license" text into the link.
  2. Result: image image

Bug URL: https://github.com/NuGet/NuGetGallery/issues/10247

erdembayar commented 2 weeks ago

@Goodyear2017 Please add any related issue link in description.

Goodyear2017 commented 2 weeks ago

@Goodyear2017 Please add any related issue link in description. I just created a bug for this issue: https://github.com/NuGet/NuGetGallery/issues/10247

agr commented 2 weeks ago

Unclear why only the license link was flagged. The download links directly below are doing the same (have text that is not a link right after the link):

image

Should those be fixed as well?

ryuyu commented 2 weeks ago

Unclear why only the license link was flagged. The download links directly below are doing the same (have text that is not a link right after the link):

image

Should those be fixed as well?

I think the existence of the parenthesis qualifies it as more than text colour differentiation, and thus this one isn't an issue? Maybe? In any case, it doesn't seem to get flagged by tools or Accessibility team.

erdembayar commented 1 week ago

I'll merge tomorrow or the day after tomorrow. Let's wait if there are any more reviews.

Happy coding! 🧑‍💻