search

NuGet / NuGetGallery

NuGet Gallery is a package repository that powers https://www.nuget.org. Use this repo for reporting NuGet.org issues.
https://www.nuget.org/
Apache License 2.0
1.55k stars 641 forks source link

Avoid calling CreateIfNotExists for Feature Flags #10258

Closed advay26 closed 1 week ago

advay26 commented 2 weeks ago

Feature flags were calling CreateIfNotExists to get the container reference for the FF container ('content'). This container already exists, so we don't need to write anything, but the CreateIfNotExists call meant that we would need to have read-write permissions enabled regardless, and jobs/services using this path would need the MSI to be over-provisioned (eg. SearchService)

I've made changes so we avoid that call for Feature Flags. I've tested it for the SearchService and it worked, but I haven't tested anything else. Let me know if there's anything else I should try to test.

Related to/Part of https://github.com/NuGet/Engineering/issues/5439

erdembayar commented 1 week ago

Please add related issue link in desc.