search

NuGet / NuGetGallery

NuGet Gallery is a package repository that powers https://www.nuget.org. Use this repo for reporting NuGet.org issues.
https://www.nuget.org/
Apache License 2.0
1.55k stars 644 forks source link

[AAD] Add AADv2 as the enforced provider for admins. #5478

Open shishirx34 opened 6 years ago

shishirx34 commented 6 years ago

Right now we are using an old provider for AAD authentication for admins. With AADv2 we can use the single flow, this will remove the need for us to depend on two providers. Also, we can simplify admin authentication to simply sign in with AAD and not use the second provider for auth. However, this would mean making sure that the credential mapping works correctly as well, the issue being that we use the name of the Provider as the credential type. That is a bad design. This will need some refactoring and ensuring we don't break anything.

skofman1 commented 6 years ago

@shishirx34 , can you add more details an explain why this is needed?

shishirx34 commented 6 years ago

@skofman1 - added.