NuGet / NuGetGallery

NuGet Gallery is a package repository that powers https://www.nuget.org. Use this repo for reporting NuGet.org issues.
https://www.nuget.org/
Apache License 2.0
1.55k stars 643 forks source link

catalog2dnx uses CDN for no-op check -- no-op check is wrong if CDN has old blob #6435

Closed joelverhagen closed 6 years ago

joelverhagen commented 6 years ago

These ones were affected, but I have reflowed them.

    EntityFramework/4.3.1
    EntityFramework/6.0.0-alpha2
    EntityFramework/6.0.0
    EntityFramework/6.0.1
    EntityFramework/6.0.2
    EntityFramework/6.1.1-beta1
    EntityFramework/6.2.0-beta1
    Microsoft.AspNet.Mvc/5.0.0
    Microsoft.AspNet.Mvc/5.1.0-rc1
    Microsoft.AspNet.Mvc/5.2.3-beta1
    Microsoft.AspNet.Mvc/5.2.4-preview1
    Microsoft.AspNet.Mvc/5.2.5-preview1
    Microsoft.AspNet.Mvc/6.0.0-rc1-final
    Microsoft.AspNet.Razor/3.2.2-rc
    Microsoft.AspNet.Razor/3.2.3-beta1
    Microsoft.AspNet.Razor/3.2.4-preview1
    Microsoft.AspNet.Razor/3.2.5-preview1
    Microsoft.AspNet.Razor/4.0.0-beta7
    Microsoft.AspNet.Razor/4.0.0-rc1-final
    Microsoft.AspNet.WebApi.Client/5.2.3-beta1
    Microsoft.AspNet.WebApi.Client/5.2.4-preview1
    Microsoft.AspNet.WebApi.Client/5.2.5-preview1
    Microsoft.AspNet.WebApi.Client/5.2.5
    Microsoft.NETCore.Platforms/1.1.0-preview1-24530-04
    Microsoft.NETCore.Platforms/2.0.0-preview1-25305-02
    Microsoft.NETCore.Platforms/2.0.0-preview2-25405-01
    Microsoft.NETCore.Platforms/2.1.0-rc1
    System.Net.Http/4.0.0
    System.Net.Http/4.1.3

For EntityFramework 4.3.1, AI logs:

traces
| where timestamp > todatetime('2018-09-11T21:54:13.390') and timestamp < todatetime('2018-09-11T21:54:17.390')
| extend jobName = tostring(customDimensions.JobName)
| extend processId = toint(customDimensions.ProcessId)
| where jobName == "catalog2dnx"
| order by processId, timestamp asc
Attempting to download package from https://api.nuget.org/packages/entityframework.4.2.0.nupkg?nuget-cache=9/11/2018 9:54:16 PM...
No changes detected: "entityframework"/"4.3.1"
loic-sharma commented 6 years ago

This should be largely fixed by @dtivel's https://github.com/NuGet/NuGet.Services.Metadata/pull/335. I will change catalog2dnx's ContentBaseAddress to point to Azure Blob Storage directly instead of CDN to bypass caching.

loic-sharma commented 6 years ago

Deployment: https://octopus.nuget.org/app#/projects/nuget-v3-catalog2dnx/releases/4.1.0-master-40362-2

loic-sharma commented 6 years ago

Verifying config with:

traces
| where customDimensions.JobName == "catalog2dnx"
| where message contains "CONFIG source:"
| order by timestamp desc
scottbommarito commented 6 years ago

PROD Global has been deployed with the ContentBaseAddress fix. Unfortunately I noticed that the ContentBaseAddress for Asia had not been changed yet. I will update the configs and redeploy Asia.