Open loic-sharma opened 3 years ago
Hey @loic-sharma - I've been looking at how this could be implemented, and at similar functionality in the code for the README tab.
I was considering, would the best way of doing this to be to pull the HTML straight from the https://licenses.nuget.org/ URL provided in the model? Or is there a better way of doing this?
I'm no longer on the team, I think @agr is likely the best contact for this question. I don't think I'd pull HTML from licenses.nuget.org as it's not clear we'd be able to style it properly.
Instead, I'd consider using ICoreLicenseFileService.DownloadLicenseFileAsync
, similar to how the existing PackagesController.License
route works.
OK thanks - I will look into it!
It could be markdown file too.
Background
Today, the information for packages' embedded license is not well integrated with nuget.org's UI. The display package page has a sidebar link to the license. For example, the MIT license links here: https://licenses.nuget.org/MIT
Solution
We are redesigning the display package page to have tabs:
Screenshot of tabs...
After this redesign is shipped, we should add a new tab for the package's license information for packages with embedded licenses: