search

NuGet / NuGetGallery

NuGet Gallery is a package repository that powers https://www.nuget.org. Use this repo for reporting NuGet.org issues.
https://www.nuget.org/
Apache License 2.0
1.55k stars 642 forks source link

[Feature]: Allow readme images from WakaTime #9447

Closed guibranco closed 1 year ago

guibranco commented 1 year ago

Related Problem

Allow readme.md files to reference images from WakaTime.

WakaTime is an open source plugin for metrics about programming. It tracks your time coding and display it's in a dashboard or via badges from https://wakatime.com domain

Sample markdown:

Time tracker

The Elevator Pitch

Add the domain wakatime.com to allowed images domains list in readme.md files

guibranco commented 1 year ago

Hi @lyndaidaii is this already in PROD ? I can't make it to work on NuGet page and also I can't find it on the docs. It was planned to 2023-04, but the PR was merged and then changed to 2023-05...The changes are already in main branch.

lyndaidaii commented 1 year ago

Hi @lyndaidaii is this already in PROD ? I can't make it to work on NuGet page and also I can't find it on the docs. It was planned to 2023-04, but the PR was merged and then changed to 2023-05...The changes are already in main branch. @guibranco, it's available in nuget.org now. Please let me know if you have any question.

guibranco commented 1 year ago

@lyndaidaii oh nice, it's working. Just the documentation is still not updated, but the images are already loading from Wakatime.

Thanks a lot!

guibranco commented 1 year ago

Hello @lyndaidaii, the documentation page at Allowed domains for images and badges still not showing the wakatime.com domain

lyndaidaii commented 1 year ago

@guibranco, thanks for reminder. I will update the documentation now.