search

NuGet / NuGetGallery

NuGet Gallery is a package repository that powers https://www.nuget.org. Use this repo for reporting NuGet.org issues.
https://www.nuget.org/
Apache License 2.0
1.52k stars 643 forks source link

Solve Package Page Tooltip Accessibility Bugs and Framework Filter Checkbox List Accessibility Bug #9900

Closed Goodyear2017 closed 2 months ago

Goodyear2017 commented 3 months ago

Disable Bootstrap popover JavaScript on framework filter and support framework badges, keep the popover classes and layout, add JavaScript function to make the tooltip popup, narrator can read the tooltip.

Add up and down arrow key JavaScript function to make users are able to use arrow keys to move between framework filter mode checkboxes. Bug links:

erdembayar commented 2 months ago

@Goodyear2017 Could you please include before and after screenshots?

Goodyear2017 commented 2 months ago

@erdembayar Please see the attached videos for before and after. before.webm after.webm

erdembayar commented 2 months ago

@erdembayar Please see the attached videos for before and after. before.webm after.webm

It's very hard for me to know difference between 2 videos, just screenshots would have been better. Also there're .pipelines/NuGetGallery-CI.yml git merge conflict, you may need to rebase your branch with dev branch.

Goodyear2017 commented 2 months ago

@martinrrm I have no clue where the files come from, I will close this PR and make a new one.

Goodyear2017 commented 2 months ago

I will close this PR and make a new one.