Fix Link Screen Reading Issue On Upload Package Page And About Page

NuGet / NuGetGallery

NuGet Gallery is a package repository that powers https://www.nuget.org. Use this repo for reporting NuGet.org issues.

https://www.nuget.org/

Apache License 2.0

1.52k stars 643 forks source link

Fix Link Screen Reading Issue On Upload Package Page And About Page #9903

Closed Goodyear2017 closed 2 months ago

Goodyear2017 commented 2 months ago

Remove aria-label and alt from links for bug # 1979902 Bug link: https://devdiv.visualstudio.com/DevDiv/_queries/edit/?tempQueryId=86f20051-1835-446b-b283-b35a28cb6618&id=1979902

ryuyu commented 2 months ago

Can we add links to the relevant bugs in the description for this, https://github.com/NuGet/NuGetGallery/pull/9901 and https://github.com/NuGet/NuGetGallery/pull/9900 ? Thanks!

Goodyear2017 commented 2 months ago

@ryuyu Just added the links to PRs, thanks!

erdembayar commented 2 months ago

Could you please include screenshot for that change if available?

Goodyear2017 commented 2 months ago

@erdembayar The change is for the link "Best Practices". Because we put a aria-label inside the link, screen reader reads the aria-label content instead of "best practices", removing the aria-label solve the issue.