search

NuGet / NuGetGallery

NuGet Gallery is a package repository that powers https://www.nuget.org. Use this repo for reporting NuGet.org issues.
https://www.nuget.org/
Apache License 2.0
1.52k stars 643 forks source link

Fix Table Text Got Truncated in Small Screen Issue #9906

Closed Goodyear2017 closed 2 months ago

Goodyear2017 commented 2 months ago

Change statistics table css to fix text truncated issue. Bug link: https://devdiv.visualstudio.com/DevDiv/_queries/edit/?tempQueryId=86f20051-1835-446b-b283-b35a28cb6618&id=1980703 https://devdiv.visualstudio.com/DevDiv/_queries/edit/?tempQueryId=86f20051-1835-446b-b283-b35a28cb6618&id=1980707

erdembayar commented 2 months ago

Please include screenshots for UI change. Could you please include before and after changes?

Goodyear2017 commented 2 months ago

@erdembayar Please see the screenshot, user can scroll left and right to see the full text after css change. image image

agr commented 2 months ago

@ryuyu, haven't we been flagged for horizontal scrollbars in the past?

ryuyu commented 2 months ago

I believe the previous flags were for horizontal scroll bars for entire page. Scroll bars that were contexted to table contents I BELIEVE were ok, so this looks like it is probably ok to me.

martinrrm commented 2 months ago

@agr @ryuyu @erdembayar Do we want to add horizontal scrolls to each row of the table? I'm not sure if that is the best approach, we could add one horizontal scroll to the table and make the table columns the size of the text, this could make some columns not visible unless scrolling to the side.

Goodyear2017 commented 2 months ago

@martinrrm We have a table on our site scroll the whole table in small screen, the accessibility team approved it.

Goodyear2017 commented 2 months ago

I will close this PR and create another one.