search

NuGet / NuGetGallery

NuGet Gallery is a package repository that powers https://www.nuget.org. Use this repo for reporting NuGet.org issues.
https://www.nuget.org/
Apache License 2.0
1.52k stars 643 forks source link

Change Link in h2 Color from Black to Blue #9908

Closed Goodyear2017 closed 2 months ago

Goodyear2017 commented 2 months ago

Change Link in h2 Color from Black to Blue Bug link: https://devdiv.visualstudio.com/DevDiv/_queries/edit/?tempQueryId=86f20051-1835-446b-b283-b35a28cb6618&id=1985625

erdembayar commented 2 months ago

@Goodyear2017 If possible please include screenshot for the UI change.

Goodyear2017 commented 2 months ago

@erdembayar Please see the screenshot for the "sign in" color change image

Goodyear2017 commented 2 months ago

Is it possible to remove the link from h2 title?

Goodyear2017 commented 2 months ago

@martinrrm Is adding underline to the link text an acceptable solution? image

Goodyear2017 commented 2 months ago

@martinrrm I had made the css change, adding underline to the link in h2. If underline is not acceptable, please suggest something.

agr commented 2 months ago

Now looking at it, the whole last section looks weird. Until then the format is: question in the header, answer/suggestion in the body. In the last item there is question and suggestion in the header and then another question and suggestion in the body... I think we need to rework the page itself a bit.

@JonDouglas any thoughts?

JonDouglas commented 2 months ago

We shouldn't put special decoration on headers if possible. We can instead just put instructions in the answer portion to instruct the user to sign in with link instead. I'd recommend removing the link in the header in this case and putting a small sentence to describe how to best contact and whether or not one needs to login to do that.

Goodyear2017 commented 2 months ago

@JonDouglas I thought removing the link from the h2 header was the best solution. You will need to give me the content that will replace what is currently there.

martinrrm commented 2 months ago

@Goodyear2017 @JonDouglas I have a fix for this issue, the color of the link, in this PR https://github.com/NuGet/NuGetGallery/pull/9914, if we still believe we need to change the text please let me know.

Goodyear2017 commented 2 months ago

@martinrrm It would be fine just change the text color. However I didn't see the change in either local environment or production.