search

NuGet / NuGetGallery

NuGet Gallery is a package repository that powers https://www.nuget.org. Use this repo for reporting NuGet.org issues.
https://www.nuget.org/
Apache License 2.0
1.52k stars 643 forks source link

remove redundant ToArray #9998

Closed SimonCropp closed 23 hours ago

joelverhagen commented 3 weeks ago

These tests are failing:

NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerAsyncMethod.RemovingNamespaceOwnerRemovesPackageVerified [FAIL] NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerAsyncMethod.MultipleNamespaceOwnersRemovalWorksCorrectly [FAIL]
NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerAsyncMethod.RemovingNamespaceOwnerAsOrganizationAdminRemovesPackageVerified [FAIL] NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerAsyncMethod.AdminCanRemoveAnyOwner [FAIL]
NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerWithMessagesAsyncMethod.RemovingNamespaceOwnerRemovesPackageVerified [FAIL]
NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerWithMessagesAsyncMethod.MultipleNamespaceOwnersRemovalWorksCorrectly [FAIL]
NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerWithMessagesAsyncMethod.RemovingNamespaceOwnerAsOrganizationAdminRemovesPackageVerified [FAIL] NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerWithMessagesAsyncMethod.AdminCanRemoveAnyOwner [FAIL]
NuGetGallery.PackageOwnershipManagementServiceFacts+TheRemovePackageOwnerWithMessagesAsyncMethod.AllowsNamespaceOwnershipToBeSkipped [FAIL]

Sample error:

    System.InvalidOperationException : Collection was modified; enumeration operation may not execute.
      Stack Trace:
           at System.Collections.Generic.HashSet`1.Enumerator.MoveNext()
           at NuGetGallery.PackageOwnershipManagementService.<RemovePackageOwnerImplAsync>d__19.MoveNext()
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
           at NuGetGallery.PackageOwnershipManagementService.<RemovePackageOwnerAsync>d__18.MoveNext()
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
           at NuGetGallery.PackageOwnershipManagementService.<RemovePackageOwnerAsync>d__17.MoveNext()
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        tests\NuGetGallery.Facts\Services\PackageOwnershipManagementServiceFacts.cs(564,0): at NuGetGallery.PackageOwnershipManagementServiceFacts.TheRemovePackageOwnerAsyncMethod.<RemovePackageOwnerAsync>d__1.MoveNext()
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        tests\NuGetGallery.Facts\Services\PackageOwnershipManagementServiceFacts.cs(669,0): at NuGetGallery.PackageOwnershipManagementServiceFacts.TheRemovePackageOwnerAsyncMethodFacts.<RemovingNamespaceOwnerRemovesPackageVerified>d__8.MoveNext()
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
SimonCropp commented 2 weeks ago

test should be fixed