Added sample to author and consume nuget package for xml transform using msbuild targets

NuGet / Samples

NuGet team sample repo

Other

136 stars 108 forks source link

Added sample to author and consume nuget package for xml transform using msbuild targets #15

Closed jainaashish closed 6 years ago

jainaashish commented 6 years ago

Added sample to author and consume nuget package for xml transform using msbuild targets for PackageReference world. This PR adds two things:

Author, which tells how to author a NuGet package to transform web.config and appconfig.config files using .transform file through msbuild targets.
Consumer, which tells how to consume a package with PackageReference which transform xml files like web.config or appconfig.config through mabuild targets.

@rrelyea

dnfclas commented 6 years ago

@jainaashish, Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request. Thanks, .NET Foundation Pull Request Bot

ryno1234 commented 5 years ago

I cannot seem to get this to work for our project. A few questions before I spend any more time debugging the issue:

Is this meant to work when the target project is an SDK-style project using the new csproj format?
Is the transform supposed to occur during installation of the Nuget package, during build of the consuming project or during publish of the consuming project?

karann-msft commented 5 years ago

@ryno1234 xdt transforms don't work with packageReference based projects and by extension, SDK-style ones https://docs.microsoft.com/en-us/nuget/reference/migrate-packages-config-to-package-reference#xdt-transforms-are-not-applied-when-the-package-is-installed-after-the-upgrade

ryno1234 commented 5 years ago

@karann-msft , Understood... however I thought the whole purpose of this sample was to demonstrate how to address that deficiency.

See https://github.com/NuGet/Home/issues/5954

karann-msft commented 5 years ago

Ah yes. You are right. I haven't tried this sample lately. Can you file an issue on the home repo with steps to repro the issue, expected, and actual behavior. Thanks!