Invalid XML in NativePackage .targets files in ExtensionSDKasNuGetPackage Sample

NuGet / Samples

NuGet team sample repo

Other

136 stars 108 forks source link

Closed TheRusstler closed 6 years ago

TheRusstler commented 6 years ago

xml

Opening Target tag on line 10 is not closed resulting in invalid XML
Build fails when importing the NativePackage NuGet package into a new UWP application

phraemer commented 6 years ago

The samples really should be working. Can someone at Micsoroft please try them all out?

Thanks!

karann-msft commented 6 years ago

@phraemer can you start a PR. We'll take a look.

phraemer commented 6 years ago

Hi,

I've fixed the ExtensionSDKasNuGetPackage examples in this PR https://github.com/NuGet/Samples/pull/26

phraemer commented 6 years ago

@karann-msft any chance you'll take a look at the PR?

phraemer commented 6 years ago

Anyone at all got time to review and merge my PR? Seems a shame to have broken examples.

karann-msft commented 6 years ago

@phraemer thanks for the PR and apologies that it took us this long to get it merged.

phraemer commented 6 years ago

No worries @karann-msft ! and thanks for merging