search

NuGet / Samples

NuGet team sample repo
Other
136 stars 108 forks source link

Created skeleton for a sample VS Credential Provider for NuGet #5

Closed xavierdecoster closed 7 years ago

xavierdecoster commented 8 years ago

Fixes NuGet/Samples#4

dnfclas commented 8 years ago

Hi @xavierdecoster, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

xavierdecoster commented 8 years ago

Looks like the NuGet.VisualStudio nupkg is no longer published as part of our CI. This package contains the IVsCredentialProvider type required for this sample to build successfully.

Blocked by https://github.com/NuGet/Home/issues/3166

xavierdecoster commented 8 years ago

Unblocked by https://github.com/NuGet/NuGet.Client/pull/912

xavierdecoster commented 8 years ago

@harikmenon @karann-msft Are there any further modifications needed to this PR? The missing NuGet.VisualStudio package issue has been resolved.

xavierdecoster commented 8 years ago

Depends on https://github.com/NuGet/NuGet.Client/pull/664

xavierdecoster commented 8 years ago

@harikmenon @karann-msft the client PR has been merged into dev. Any further changes needed to this PR? This PR needs to go in before the related docs PR can go in (otherwise, it'll have a broken link to this sample).

karann-msft commented 8 years ago

@yishaigalatzer @alpaix please review.