(*) replaced tabs with spaces; dont use tabs plz

NuGrid / NuGridPy

Python tools to access and analyse NuGrid output data (including from MESA)

http://nugrid.github.io/NuGridPy

BSD 3-Clause "New" or "Revised" License

13 stars 10 forks source link

(*) replaced tabs with spaces; dont use tabs plz #2

Closed korobkin closed 8 years ago

korobkin commented 8 years ago

Let's never use mixed tabs and spaces in python scripts. Only spaces should be allowed, as described in this Python programming guide: http://legacy.python.org/dev/peps/pep-0008/#tabs-or-spaces

I have replaced tabs with spaces in all these scripts, but now somebody should probably check if they still work. Wrong indentation in Python can cause very serious bugs, which are hard to find.

fherwig commented 8 years ago

@adam-paul @OClarkson @critter1 @swjones

develop some basic tests if the python tools are working
apply to this branch
@adam-paul merge pull request
@adam-paul implement in travis-ci

2sn commented 8 years ago

@fherwig @korobkin with the new fixes I can now cleanly import the new branch. As a result, a first very basic "test suite" we should create is to just import all modules ...

korobkin commented 8 years ago

@2sn @fherwig I am going to kill this branch to avoid confusion. This is now superseded by #5

2sn commented 8 years ago

@korobkin - please check my version whether it seems OK to you.,

On 7 June 2016 at 09:08, korobkin notifications@github.com wrote:

I am going to kill this branch to avoid confusion. This is now superseded by #3 https://github.com/NuGrid/NuGridPy/issues/3

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NuGrid/NuGridPy/pull/2#issuecomment-224115993, or mute the thread https://github.com/notifications/unsubscribe/ABNtFkhgZFsJcyNyrf_IFy5Cy4rGdb-eks5qJKh7gaJpZM4IoCPW .

Sent from gmail.